Comments on: Formatting a phone number in ASP.NET data bound controls http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/ The scratchpad, the holding area, the ranting place Thu, 28 Aug 2008 01:33:17 +0000 http://wordpress.org/?v=2.1 By: harsha http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-50 harsha Thu, 08 Dec 2005 20:45:55 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-50 rice one..it would rather do all my formating on client side... rice one..it would rather do all my formating on client side…

]]> By: harsha http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-51 harsha Thu, 08 Dec 2005 20:48:02 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-51 What i really meant was that I would my formating using javascript/vbscript ...:) What i really meant was that I would my formating using javascript/vbscript …:)

]]> By: Luke http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-52 Luke Thu, 08 Dec 2005 21:00:15 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-52 Yeah, but the idea here is to do less work, not more. Do you have a URL with an example of formatting a phone number via javascript? It sounds like overkill to me... Luke Yeah, but the idea here is to do less work, not more. Do you have a URL with an example of formatting a phone number via javascript? It sounds like overkill to me…

Luke

]]> By: Kelly http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-58 Kelly Tue, 14 Mar 2006 20:12:44 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-58 Luke, you are the man. I've been trying to use formatting in item templates with the old VBScript formatting functions and sometimes they just don't work. It never occurred to me that I could use the String.Format Static method in the HTML. Thanks Luke, you are the man. I’ve been trying to use formatting in item templates with the old VBScript formatting functions and sometimes they just don’t work. It never occurred to me that I could use the String.Format Static method in the HTML. Thanks

]]> By: Luke http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-59 Luke Tue, 14 Mar 2006 21:49:49 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-59 Funny you should mention that today, Kelly, I just did a weird bit of data binding this morning that reminded me of this post! I should get off my butt and write more about this stuff, it's the only way I'll remember it... Funny you should mention that today, Kelly, I just did a weird bit of data binding this morning that reminded me of this post! I should get off my butt and write more about this stuff, it’s the only way I’ll remember it…

]]> By: jeaux http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-1961 jeaux Mon, 16 Oct 2006 18:22:26 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-1961 DataBinder.Eval(Container.DataItem, "Phone_Number","{0:(###) ###-####}") DataBinder.Eval(Container.DataItem, “Phone_Number”,”{0:(###) ###-####}”)

]]> By: Jason http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-2005 Jason Fri, 27 Oct 2006 14:43:05 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-2005 Jeaux, that won\'t work - the var is defined as a string, so the formatting is pretty much ignored, as far as I can tell - you need to convert it to a number first.  I had a lovely example page made up, but WP doesn\'t want to let me add it to the comments, so you\'ll just have to trust me, or try it for yourself. Jeaux, that won\’t work - the var is defined as a string, so the formatting is pretty much ignored, as far as I can tell - you need to convert it to a number first.  I had a lovely example page made up, but WP doesn\’t want to let me add it to the comments, so you\’ll just have to trust me, or try it for yourself.

]]> By: Victor Escobar http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-8223 Victor Escobar Sun, 20 May 2007 22:44:11 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-8223 When I used your code, I got the following error: Object cannot be cast from DBNull to other types. Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code. Exception Details: System.InvalidCastException: Object cannot be cast from DBNull to other types. Source Error: Line 40: HeaderText="Phone Number" SortExpression="strPhoneNumber"> Line 41: Line 42: Line 43: Line 44: Source File: C:\inetpub\XXX\YYY\ZZZ.aspx Line: 42 Stack Trace: [InvalidCastException: Object cannot be cast from DBNull to other types.] System.DBNull.System.IConvertible.ToInt64(IFormatProvider provider) +54 System.Convert.ToInt64(Object value) +25 ASP.admin_admin_evaluator_aspx.__DataBind__control16(Object sender, EventArgs e) in C:\inetpub\XXX\YYY\ZZZ.aspx:42 System.Web.UI.Control.OnDataBinding(EventArgs e) +99 System.Web.UI.Control.DataBind(Boolean raiseOnDataBinding) +206 System.Web.UI.Control.DataBind() +12 System.Web.UI.Control.DataBindChildren() +216 System.Web.UI.Control.DataBind(Boolean raiseOnDataBinding) +216 System.Web.UI.Control.DataBind() +12 System.Web.UI.Control.DataBindChildren() +216 System.Web.UI.Control.DataBind(Boolean raiseOnDataBinding) +216 System.Web.UI.Control.DataBind() +12 System.Web.UI.WebControls.GridView.CreateRow(Int32 rowIndex, Int32 dataSourceIndex, DataControlRowType rowType, DataControlRowState rowState, Boolean dataBind, Object dataItem, DataControlField[] fields, TableRowCollection rows, PagedDataSource pagedDataSource) +221 System.Web.UI.WebControls.GridView.CreateChildControls(IEnumerable dataSource, Boolean dataBinding) +3004 System.Web.UI.WebControls.CompositeDataBoundControl.PerformDataBinding(IEnumerable data) +59 System.Web.UI.WebControls.GridView.PerformDataBinding(IEnumerable data) +11 System.Web.UI.WebControls.DataBoundControl.OnDataSourceViewSelectCallback(IEnumerable data) +111 System.Web.UI.DataSourceView.Select(DataSourceSelectArguments arguments, DataSourceViewSelectCallback callback) +29 System.Web.UI.WebControls.DataBoundControl.PerformSelect() +149 System.Web.UI.WebControls.BaseDataBoundControl.DataBind() +70 System.Web.UI.WebControls.GridView.DataBind() +4 System.Web.UI.WebControls.BaseDataBoundControl.EnsureDataBound() +82 System.Web.UI.WebControls.CompositeDataBoundControl.CreateChildControls() +69 System.Web.UI.Control.EnsureChildControls() +87 System.Web.UI.Control.PreRenderRecursiveInternal() +41 System.Web.UI.Control.PreRenderRecursiveInternal() +161 System.Web.UI.Control.PreRenderRecursiveInternal() +161 System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint) +1360 -------------------------------------------------------------------------------- Version Information: Microsoft .NET Framework Version:2.0.50727.42; ASP.NET Version:2.0.50727.210 When I used your code, I got the following error:

Object cannot be cast from DBNull to other types.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.InvalidCastException: Object cannot be cast from DBNull to other types.

Source Error:

Line 40: HeaderText=”Phone Number” SortExpression=”strPhoneNumber”>
Line 41:
Line 42:
Line 43:
Line 44:

Source File: C:\inetpub\XXX\YYY\ZZZ.aspx Line: 42

Stack Trace:

[InvalidCastException: Object cannot be cast from DBNull to other types.]
System.DBNull.System.IConvertible.ToInt64(IFormatProvider provider) +54
System.Convert.ToInt64(Object value) +25
ASP.admin_admin_evaluator_aspx.__DataBind__control16(Object sender, EventArgs e) in C:\inetpub\XXX\YYY\ZZZ.aspx:42
System.Web.UI.Control.OnDataBinding(EventArgs e) +99
System.Web.UI.Control.DataBind(Boolean raiseOnDataBinding) +206
System.Web.UI.Control.DataBind() +12
System.Web.UI.Control.DataBindChildren() +216
System.Web.UI.Control.DataBind(Boolean raiseOnDataBinding) +216
System.Web.UI.Control.DataBind() +12
System.Web.UI.Control.DataBindChildren() +216
System.Web.UI.Control.DataBind(Boolean raiseOnDataBinding) +216
System.Web.UI.Control.DataBind() +12
System.Web.UI.WebControls.GridView.CreateRow(Int32 rowIndex, Int32 dataSourceIndex, DataControlRowType rowType, DataControlRowState rowState, Boolean dataBind, Object dataItem, DataControlField[] fields, TableRowCollection rows, PagedDataSource pagedDataSource) +221
System.Web.UI.WebControls.GridView.CreateChildControls(IEnumerable dataSource, Boolean dataBinding) +3004
System.Web.UI.WebControls.CompositeDataBoundControl.PerformDataBinding(IEnumerable data) +59
System.Web.UI.WebControls.GridView.PerformDataBinding(IEnumerable data) +11
System.Web.UI.WebControls.DataBoundControl.OnDataSourceViewSelectCallback(IEnumerable data) +111
System.Web.UI.DataSourceView.Select(DataSourceSelectArguments arguments, DataSourceViewSelectCallback callback) +29
System.Web.UI.WebControls.DataBoundControl.PerformSelect() +149
System.Web.UI.WebControls.BaseDataBoundControl.DataBind() +70
System.Web.UI.WebControls.GridView.DataBind() +4
System.Web.UI.WebControls.BaseDataBoundControl.EnsureDataBound() +82
System.Web.UI.WebControls.CompositeDataBoundControl.CreateChildControls() +69
System.Web.UI.Control.EnsureChildControls() +87
System.Web.UI.Control.PreRenderRecursiveInternal() +41
System.Web.UI.Control.PreRenderRecursiveInternal() +161
System.Web.UI.Control.PreRenderRecursiveInternal() +161
System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint) +1360

——————————————————————————–
Version Information: Microsoft .NET Framework Version:2.0.50727.42; ASP.NET Version:2.0.50727.210

]]> By: Jason http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-8300 Jason Tue, 22 May 2007 16:02:34 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-8300 Victor, can you email me the source file so I can see what else is going on? I'll try to put an update on demos tonight... Victor, can you email me the source file so I can see what else is going on? I’ll try to put an update on demos tonight…

]]> By: Kathleen Anderson http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-10076 Kathleen Anderson Sun, 08 Jul 2007 02:00:23 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-10076 Thanks for this - I have been Googling for the last 24 hours for something like this. I did find your syntax was off just a tad - this is what worked for me: ' Thanks for this - I have been Googling for the last 24 hours for something like this. I did find your syntax was off just a tad - this is what worked for me:

‘

]]> By: Kathleen Anderson http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-10077 Kathleen Anderson Sun, 08 Jul 2007 02:05:39 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-10077 String.Format("{0:(###) ###-####}", Convert.ToInt64(DataBinder.Eval(Container.DataItem,"homephone"))) String.Format(”{0:(###) ###-####}”, Convert.ToInt64(DataBinder.Eval(Container.DataItem,”homephone”)))

]]> By: Cetin Basoz http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-12222 Cetin Basoz Sat, 18 Aug 2007 15:29:22 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-12222 Pardon me but telephone numbers are not made up of digits all the time. Wouldn't something like this cause a parsing error? 800VERIZON or (formatted): +1 (555) 1234567 [1234] +1 555 1234567 - 1234 +1 555 123 45 67 - 1234 00 1 (555) 1234567 444 0 MSI etc. Maybe storing it as end users wrote is the way. People are accustomed to type in such data in the format they are familiar most. To me it's neither the job of data layer nor presentation. Humans can easily interpret those numbers. Pardon me but telephone numbers are not made up of digits all the time. Wouldn’t something like this cause a parsing error?

800VERIZON

or (formatted):

+1 (555) 1234567 [1234]
+1 555 1234567 - 1234
+1 555 123 45 67 - 1234
00 1 (555) 1234567
444 0 MSI

etc.

Maybe storing it as end users wrote is the way. People are accustomed to type in such data in the format they are familiar most.
To me it’s neither the job of data layer nor presentation. Humans can easily interpret those numbers.

]]> By: ASP.NET Applications http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-17643 ASP.NET Applications Tue, 09 Oct 2007 08:02:35 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-17643 Good info. But I agree with the Harsh- I prefer the client side to do all the ugly work... Good info. But I agree with the Harsh- I prefer the client side to do all the ugly work…

]]> By: ASP.NET Applications http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-19902 ASP.NET Applications Wed, 24 Oct 2007 12:09:07 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-19902 Great post I agree with Cetin Basoz. I believe that storing it as the users do- is the way. Great post
I agree with Cetin Basoz.
I believe that storing it as the users do- is the way.

]]> By: Jeremy http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-24697 Jeremy Wed, 28 Nov 2007 17:57:21 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-24697 Actually, it would be best to parse the digits out when accepting the data using regex. Storing various formats of the same style is a nightmare to maintain. Taking a we'll-just-deal-with-whatever-they-input approach will eventually cause a lot of problems (especially on the security side). Actually, it would be best to parse the digits out when accepting the data using regex. Storing various formats of the same style is a nightmare to maintain. Taking a we’ll-just-deal-with-whatever-they-input approach will eventually cause a lot of problems (especially on the security side).

]]> By: Haniel Croitoru http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-26252 Haniel Croitoru Wed, 26 Dec 2007 04:43:39 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-26252 Hi all, This post is very useful. One additional question I have on this is, how do I deal with the situation where the phone number may be blank? The browser throws an exception at that point. Hi all,

This post is very useful. One additional question I have on this is, how do I deal with the situation where the phone number may be blank? The browser throws an exception at that point.

]]> By: Andy http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-26421 Andy Fri, 28 Dec 2007 20:59:49 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-26421 public static string FormatPhoneNumber(string pNum) { pNum = RemoveNonIntegers(pNum); if (pNum.Length == 10) return String.Format("{0:(###) ###-####}", Int64.Parse(pNum)); else if (pNum.Length == 7) return String.Format("{0:###-####}", Int64.Parse(pNum)); else return "Invalid string format"; } public static string FormatPhoneNumber(string pNum)
{
pNum = RemoveNonIntegers(pNum);
if (pNum.Length == 10)
return String.Format(”{0:(###) ###-####}”, Int64.Parse(pNum));
else if (pNum.Length == 7)
return String.Format(”{0:###-####}”, Int64.Parse(pNum));
else return “Invalid string format”;
}

]]> By: Jason http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-26663 Jason Tue, 01 Jan 2008 16:42:15 +0000 http://www.thrustlabs.com/blog/2005/12/08/formatting-a-phone-number-in-aspnet-data-bound-controls/#comment-26663 Haniel, there's not a lot of error handling (i.e. none) in this technique - a helper function like Andy provided would be a better approach here. Haniel, there’s not a lot of error handling (i.e. none) in this technique - a helper function like Andy provided would be a better approach here.

]]>